Skip to content

Refactor the D3D12 API. #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Refactor the D3D12 API. #839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ First create an allocator then create allocations from it:
```cpp
#include <gpgmm_d3d12.h>

gpgmm::d3d12::ALLOCATOR_DESC allocatorDesc = {};
gpgmm::d3d12::RESOURCE_ALLOCATOR_DESC allocatorDesc = {};

ComPtr<gpgmm::d3d12::IResidencyManager> residency; // Optional
ComPtr<gpgmm::d3d12::IResourceAllocator> allocator;
Expand Down Expand Up @@ -58,13 +58,13 @@ list->Reset();
Residency also works for non-resources too:

```cpp
gpgmm::d3d12::HEAP_DESC shaderVisibleHeap = {};
gpgmm::d3d12::RESIDENCY_HEAP_DESC shaderVisibleHeap = {};
shaderVisibleHeap.SizeInBytes = kHeapSize;
shaderVisibleHeap.HeapSegment = DXGI_MEMORY_SEGMENT_GROUP_LOCAL;

ComPtr<gpgmm::d3d12::IHeap> descriptorHeap;
ComPtr<gpgmm::d3d12::IResidencyHeap> descriptorHeap;
CreateHeapContext createHeapContext(heapDesc);
gpgmm::d3d12::CreateHeap(shaderVisibleHeap, residencyManager,
gpgmm::d3d12::CreateResidencyHeap(shaderVisibleHeap, residencyManager,
createHeapContext, &CreateHeapContext::CreateHeapCallbackWrapper,
&descriptorHeap);

Expand Down
2 changes: 1 addition & 1 deletion docs/DESIGN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ sequenceDiagram
GPGMM->>GPGMM: Pool-allocate
Note over GPGMM: No heaps in pool.
activate D3D12
GPGMM->>D3D12: CreateHeap
GPGMM->>D3D12: CreateResidencyHeap
D3D12-->>GPGMM: new Heap
Note over GPGMM: Track Heap for residency.
GPGMM->>D3D12: CreatePlacedResource
Expand Down
Loading