vsock: fix issues with large chunk transmission #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send credit update packets when calculated free space (based on previously advertised fwd_cnt) falls below max packet size after receiving data, preventing peer from blocking due to outdated credit information. Signed-off-by: Jiaqi Gao <jiaqi.gao@intel.com>
Split outgoing data larger than MAX_VSOCK_PKT_DATA_LEN into multiple packets to avoid qemu errors. Kernel/qemu implementations limit the packet size and cause failures when exceeded. Signed-off-by: Jiaqi Gao <jiaqi.gao@intel.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| let remaining = total_len - bytes_sent; | ||
| let available_space = self.peer_free_space() as usize; | ||
| let chunk_size = remaining | ||
| .min(MAX_VSOCK_PKT_DATA_LEN as usize) |
Check warning
Code scanning / clippy
casting to the same type is unnecessary (usize -> usize) Warning
jyao1
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #452
Closes #453