Spdm attestation should check event_log received during attestation #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IntelCaisui
force-pushed
the
251024_ADD_VERIFY_POLICY_SPDM
branch
2 times, most recently
from
aad9845 to
09fce07
Compare
jyao1
reviewed
Oct 27, 2025
src/migtd/src/spdm/spdm_req.rs
Outdated
Comment on lines
543
to
544
| #[allow(unused_variables)] | ||
| let event_log_dst = reader.take(vdm_element.length as usize).unwrap(); |
Contributor
Author
There was a problem hiding this comment.
#[allow(unused_variables)]
could
be updated as
#[cfg(not(feature = "policy_v2"))]
Will update that. Same change will be applied to similar changes.
jyao1
reviewed
Oct 27, 2025
Comment on lines
323
to
368
| let _event_log_dst = reader.take(vdm_element.length as usize).unwrap(); | ||
| #[allow(unused_variables)] | ||
| let event_log_src = reader.take(vdm_element.length as usize).unwrap(); |
IntelCaisui
force-pushed
the
251024_ADD_VERIFY_POLICY_SPDM
branch
2 times, most recently
from
bf540c7 to
1190f1c
Compare
Add policy v1 support for spdm attestation. Also rename the quote, event_log, policy_hash based on src and dst to improvement code readability.
IntelCaisui
force-pushed
the
251024_ADD_VERIFY_POLICY_SPDM
branch
from
1190f1c to
60e9d16
Compare
jyao1
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add policy v1 support for spdm attestation.
Also rename the quote, event_log, policy_hash based on src and dst
to improvement code readability.