Skip to content

Conversation

@gaojiaqi7
Copy link
Contributor

No description provided.

Signed-off-by: Jiaqi Gao <jiaqi.gao@intel.com>
Signed-off-by: Jiaqi Gao <jiaqi.gao@intel.com>
@gaojiaqi7 gaojiaqi7 requested a review from jyao1 as a code owner December 2, 2025 06:20
@gaojiaqi7 gaojiaqi7 requested a review from liuw1 December 2, 2025 06:25
jyao1
jyao1 previously approved these changes Dec 2, 2025
///
/// Run with: cargo test test_thim_headers -- --nocapture
/// Set AZURE_REGION environment variable or it defaults to "useast"
/// Ignored in CI because it requires network access to Azure THIM.
Copy link
Contributor

@jyao1 jyao1 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bodzhang, do you know why we cannot access Azure THIM?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THIM service endpoint is only reachable from within Azure environment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means we are not able to run this test.

Can we have a way to skip this test?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for Ci env without THIM access, and it is not critical enough to block PRs. Dev can still run this unit test locally even with [ignore]

@jyao1 jyao1 dismissed their stale review December 2, 2025 07:57

Need more review for CI ignore

@jyao1 jyao1 merged commit 700463d into intel:main Dec 3, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants