Fixes to SERVTD_EXT w.r.t padding and zeroing#762
Merged
jyao1 merged 1 commit intointel:mainfrom Mar 25, 2026
Merged
Conversation
Contributor
Author
|
@jyao1 Please let me know if I should zero the cur_servtd_attr (currently since its already 0, it didnt affect my testing) as well, given 4.1.1.6 from SAS mentions MigTD should zero both cur_servtd_attr and cur_servtd_hash before calculating hash of servtd_ext_struct. Thanks! |
Contributor
|
yes, please always follow the spec. |
Contributor
Author
|
thanks for the quick update. I have added the code for cur_servtd_attr as well. Kindly review. |
jyao1
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current SERVTD_EXT is not 8 bytes aligned, adding the 4 byte padding fix and also SAS mentions to zero cur_servtd_hash