fix(servtd_ext): remove broken init_attr == curr_attr check#857
Open
sgrams wants to merge 1 commit into
Open
Conversation
The verify_servtd_attr and read_servtd_ext functions compared CURR_SERVTD_ATTR against INIT_ATTR read from the target TD. This check is invalid because INIT_ATTR is only populated when the rebind feature is supported, while the initial binding does not set it. Remove the redundant INIT_ATTR comparison and keep only the hardcoded EXPECTED_SERVTD_ATTR verification which ensures the VMM wrote the correct value. Signed-off-by: Stanislaw Grams <stanislaw.grams@intel.com>
Contributor
|
@haitaohuang , could you please take a look? |
Contributor
|
LGTM, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verify_servtd_attr and read_servtd_ext functions compared CURR_SERVTD_ATTR against INIT_ATTR read from the target TD. This check is invalid because INIT_ATTR is only populated when the rebind feature is supported, while the initial binding does not set it.
Remove the redundant INIT_ATTR comparison and keep only the hardcoded EXPECTED_SERVTD_ATTR verification which ensures the VMM wrote the correct value.
Closes #845