no targets when --input present#310
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the target connection logic so that when the --input flag is specified, the process reads outputs from the input file and bypasses target connection attempts. Key changes include:
- Adding a conditional block to read outputs from input when FlagInput is not empty.
- Replacing the call to rc.RetrieveScriptOutputs with a direct call to outputsFromTargets.
- Removing the now redundant RetrieveScriptOutputs function.
Comments suppressed due to low confidence (1)
internal/common/common.go:125
- [nitpick] Consider consolidating error logging to a single helper to avoid duplicate error outputs, as the error is both printed to stderr and passed to slog.Error.
fmt.Fprintf(os.Stderr, "Error: %v\n", err)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if --input present don't create or attempt to connect to target(s)