make sure target name in targets.yaml file doesn't include any characters that can alter the output location#333
Merged
Merged
Conversation
…ters that can alter the output location Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a function to sanitize target names read from targets.yaml to prevent characters that may alter output locations.
- Introduces a new sanitizeTargetName function to restrict allowed characters in a target name
- Updates the instantiation of remote targets to use the sanitized target name
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
…ization Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
echiugoog
pushed a commit
to echiugoog/PerfSpect
that referenced
this pull request
May 21, 2025
…ters that can alter the output location (intel#333) * make sure target name in targets.yaml file doesn't include any characters that can alter the output location Signed-off-by: Harper, Jason M <jason.m.harper@intel.com> * update comment Signed-off-by: Harper, Jason M <jason.m.harper@intel.com> * Enhance target name sanitization to prevent duplicates in targets file Signed-off-by: Harper, Jason M <jason.m.harper@intel.com> * Add unit tests for sanitizeTargetName function to validate name sanitization Signed-off-by: Harper, Jason M <jason.m.harper@intel.com> --------- Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.