Skip to content

add NIC vendor and model IDs to report#366

Merged
harp-intel merged 2 commits into
mainfrom
nicids
Jun 5, 2025
Merged

add NIC vendor and model IDs to report#366
harp-intel merged 2 commits into
mainfrom
nicids

Conversation

@harp-intel
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
@harp-intel harp-intel linked an issue Jun 4, 2025 that may be closed by this pull request
@harp-intel harp-intel requested a review from Copilot June 4, 2025 23:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances NIC reporting by including vendor and model identifiers alongside existing vendor/model names.

  • Adds shell commands to extract Vendor ID and Model ID in the NIC inspection script.
  • Extends the nicInfo struct and parsing logic to capture these IDs.
  • Updates table definitions to display IDs in the report columns.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
internal/script/script_defs.go Echoes Vendor ID and Model ID per interface
internal/report/table_helpers.go Adds VendorID and ModelID fields and parsing
internal/report/table_defs.go Renames columns to include (ID) and appends IDs
Comments suppressed due to low confidence (1)

internal/report/table_helpers.go:1333

  • The new VendorID and ModelID fields are not covered by existing unit tests. Add tests for parseNicInfo to verify that both IDs are correctly parsed from script output.
VendorID        string

Comment thread internal/script/script_defs.go Outdated
Comment thread internal/report/table_defs.go
…ability

Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
@harp-intel harp-intel merged commit 98f89d3 into main Jun 5, 2025
4 checks passed
@harp-intel harp-intel deleted the nicids branch June 5, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add vendor ID and model ID to NIC table in report

2 participants