fix determination of availability of fixed counters#367
Merged
Conversation
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the loop bounds when generating the fixed counter event lists so that the general-purpose counters are overflowed one extra time to confirm support for fixed counters.
- Increase iterations by one for both
instructionsandcpu-cyclesevent lists. - Update script templates to use the extended event lists.
Comments suppressed due to low confidence (2)
cmd/metrics/metadata.go:311
- The expression
for range numGPCounters + 1is invalid in Go becauserangerequires a slice, array, string, map, or channel. Replace it with a standard integer loop, e.g.for i := 0; i < numGPCounters+1; i++.
for range numGPCounters + 1 {
cmd/metrics/metadata.go:317
- Similarly,
for range numGPCounters + 1will not compile. Use an index-based loop (for i := 0; i < numGPCounters+1; i++) or construct a slice of the correct length before ranging.
for range numGPCounters + 1 {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
need to overflow the GP counters to determine if the fixed counter is supported