rename flame command to flamegraph, accept flame as alias #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request renames the
flamecommand and all related files, code, and documentation references toflamegraphfor improved clarity and consistency. Additionally, it refactors the lock command's table rendering code by moving the HTML renderer to its own file. Below are the most important changes grouped by theme:Command and Codebase Renaming:
flamecommand and all related code, files (e.g.,cmd/flame/flame.gotocmd/flamegraph/flamegraph.go), and documentation references toflamegraphto standardize terminology. The new command also includesflameas an alias for backward compatibility. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Lock Command Refactor:
kernelLockAnalysisHTMLRendererfunction fromcmd/lock/lock_tables.goto a new filecmd/lock/lock_renderers.goto separate rendering logic from table value logic, improving code organization and maintainability. [1] [2] [3]