fix: add alias for IntelLLVM compiler #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaic
requested changes
Feb 24, 2025
ahuber21
commented
Feb 25, 2025
| mutable_data_view(destination), | ||
| std::span<const uint64_t>(ids.template mutable_unchecked().mutable_data(), num_ids) | ||
| std::span<const uint64_t>( | ||
| ids.template mutable_unchecked<-1>().mutable_data(), num_ids |
Contributor
Author
There was a problem hiding this comment.
For using oneapi compiler it is necessary to provide <-1> (default value for the Dims template parameter in mutable_unchecked()) to avoid a compiler warning that gets promoted to an error
manager.h:122:48: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
mihaic
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the correct
archspecname forCMakeIntelLLVM.