Skip to content

fix: add alias for IntelLLVM compiler #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 27, 2025
+4 −1
Merged

fix: add alias for IntelLLVM compiler #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a27188
fix: add alias for IntelLLVM compiler
ahuber21 Feb 24, 2025
6a5c10a
fix archspec compiler name and template compiler warning
ahuber21 Feb 25, 2025
5f030d3
Merge branch 'main' into dev/ahuber/microarch-intl-alias
ahuber21 Feb 27, 2025
bef34c8
Merge branch 'main' into dev/ahuber/microarch-intl-alias
ahuber21 Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bindings/python/include/svs/python/manager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ reconstruct(Index& index, py_contiguous_array_t<uint64_t> ids) {
auto destination = py_contiguous_array_t<float>({num_ids, data_dims});
index.reconstruct_at(
mutable_data_view(destination),
std::span<const uint64_t>(ids.template mutable_unchecked().mutable_data(), num_ids)
std::span<const uint64_t>(
ids.template mutable_unchecked<-1>().mutable_data(), num_ids
Copy link
Contributor Author

@ahuber21 ahuber21 Feb 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For using oneapi compiler it is necessary to provide <-1> (default value for the Dims template parameter in mutable_unchecked()) to avoid a compiler warning that gets promoted to an error

manager.h:122:48: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]

)
);

// Reshape the destination to have the same shape as the original IDs (plus the extra
Expand Down
1 change: 1 addition & 0 deletions bindings/python/microarch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ def resolve_compiler(name: str):
aliases = {
"GNU": "gcc",
"Clang": "clang",
"IntelLLVM": "oneapi",
}
return aliases.get(name, name)

Expand Down
Loading