fix torch dtype #1217
Merged
fix torch dtype #1217
+61
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenhuach21
requested review from
Copilot,
n1ck-guo and
yiliu30
and removed request for
n1ck-guo
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a compatibility issue with torch dtype parameter naming in transformers library by implementing a monkey patch. The change ensures the codebase works across different versions of transformers (before and after version 4.56.0), where the parameter name for specifying torch dtype changed from torch_dtype to dtype.
- Adds a decorator-based parameter renaming mechanism to handle the torch dtype parameter name change
- Implements monkey patching for transformers AutoModelForCausalLM to maintain compatibility across versions
- Automatically applies the monkey patch at module initialization
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| auto_round/utils/common.py | Adds rename_kwargs decorator and monkey patching functions to handle torch dtype parameter compatibility |
| auto_round/init.py | Imports and executes the monkey patch at module initialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
for more information, see https://pre-commit.ci
…into fix_torch_dtype # Conflicts: # auto_round/utils/common.py
for more information, see https://pre-commit.ci
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
for more information, see https://pre-commit.ci
xin3he
approved these changes
Jan 5, 2026
Contributor
xin3he
left a comment
xin3he
left a comment
There was a problem hiding this comment.
This monkey_patch_transformers is really cool!
yiliu30
approved these changes
Jan 5, 2026
…into fix_torch_dtype
for more information, see https://pre-commit.ci
chensuyue
reviewed
Jan 5, 2026
…into fix_torch_dtype # Conflicts: # test/test_ark/test_model.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.