Conversation
Signed-off-by: He, Xin3 <xin3.he@intel.com>
25 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CUDA test cases to call evaluate_accuracy with a new/adjusted argument pattern (removing the explicit model="hf" parameter), aiming to fix a typo/bug in how accuracy evaluation is invoked.
Changes:
- Updated multiple tests to call
evaluate_accuracywithoutmodel="hf"and to pass the model args positionally. - Adjusted the multi-GPU test to pass
self.save_dirdirectly intoevaluate_accuracy.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
| test/test_cuda/quantization/test_2_3bits.py | Updates evaluate_accuracy calls in quantization flow tests. |
| test/test_cuda/core/test_main_func.py | Updates evaluate_accuracy calls across main CUDA backend tests. |
| test/test_cuda/advanced/test_multiple_card.py | Changes evaluate_accuracy invocation in multi-card device-map test. |
Kaihui-intel
approved these changes
Feb 11, 2026
lvliang-intel
pushed a commit
that referenced
this pull request
Feb 27, 2026
Signed-off-by: He, Xin3 <xin3.he@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
typo fix
Type of Change
Related Issues
Fixes or relates to #1315
Checklist Before Submitting