Add handle_generation_config function to manage model generation_config saving failure#1448
Merged
Add handle_generation_config function to manage model generation_config saving failure#1448
Conversation
…ig saving failure
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a helper to adjust generation_config.do_sample based on sampling-related parameters to avoid failures when working with non-default generation settings.
Changes:
- Invoke a new
handle_generation_config()during both LLM and MLLM model load flows. - Add
handle_generation_config()to setdo_sample=Truewhentop_p,top_k, ortemperatureindicates sampling.
hshen14
reviewed
Feb 12, 2026
hshen14
approved these changes
Feb 12, 2026
Signed-off-by: He, Xin3 <xin3.he@intel.com>
n1ck-guo
approved these changes
Feb 28, 2026
wenhuach21
reviewed
Feb 28, 2026
wenhuach21
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
huggingface/transformers#43937
Type of Change
Related Issues
Fixes or relates to #
Checklist Before Submitting