🐛 Fix lists with incomplete types#362
Merged
Merged
Conversation
Problem: - `intrusive_list` and `intrusive_forward_list` are constrained so that they can take incomplete types. This means using an incomplete type in a SFINAE context, which causes an error with GCC 16 (probably because it can lead to an ODR violation). Solution: - Use mandates, not requires; i.e. instead of concept-constraining, `static_assert` completeness in functions that need it.
mjcaisse-intel
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
intrusive_listandintrusive_forward_listare constrained so that they can take incomplete types. This means using an incomplete type in a SFINAE context, which causes an error with GCC 16 (probably because it can lead to an ODR violation).Solution:
static_assertcompleteness in functions that need it.