Move to pull-style config update strategy #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JonatanWaern
commented
May 28, 2025
JonatanWaern
commented
- Handle parsing of responses correctly
- Support the sending of requests that require responses and implement this for workspace/configuration
- Dont bother the server with unknown configs
Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
and implement this for workspace/configuration Signed-off-by: Jonatan Waern<jonatan.waern@intel.com>
When we get vscode to only send the relevant-for-dls configs (whether that is by specifying a new domain for them, or by filtering manually) we can revert this Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
JonatanWaern
force-pushed
the
new-config-strategy
branch
from
50b36a1 to
77f6986
Compare
Contributor
Author
|
Not entirely satisfied with this yet. Would like to actually re-do lint analysis based on the config change. |
Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
Imposes unnecessary restrictions on code that can be written on them, and incorrectly gives the impression that modifying the InitActionContext directly is valid (it's usually not) Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
JonatanWaern
force-pushed
the
new-config-strategy
branch
from
77f6986 to
1518e98
Compare
Contributor
Author
now fixed |
MagnusIntel
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.