Fixes related to paramater resolution #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonatanWaern
force-pushed
the
disable-register-size-check
branch
2 times, most recently
from
a786229 to
0d0d254
Compare
JonatanWaern
changed the title
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes parameter resolution issues and improves various aspects of the codebase. The changes primarily focus on correcting template parameter handling and fixing formatting inconsistencies.
- Fixed debug formatting in span structures by removing extra parentheses
- Improved parameter tracking for in-each statements by properly flattening their statements
- Moved parameter invariant checks to a more appropriate location in the analysis pipeline
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/span/mod.rs | Fixed debug formatting for Column and Row structs |
| src/analysis/templating/objects.rs | Updated method call and removed unused parameter invariant function |
| src/analysis/structure/toplevel.rs | Enhanced in-each statement processing to properly track nested statements |
| src/analysis/mod.rs | Moved parameter invariant checks to DeviceAnalysis with updated implementation |
| CHANGELOG.md | Added release notes for the fixes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JonatanWaern
force-pushed
the
disable-register-size-check
branch
from
0d0d254 to
4e4bd21
Compare
TSonono
approved these changes
Sep 18, 2025
JonatanWaern
force-pushed
the
disable-register-size-check
branch
from
3413d28 to
a077246
Compare
Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
This will rely on future constant-folding, in order to ascertain that an actual value is found. Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
It was getting to an unwieldy length, assists with method-level profiling Signed-off-by: Jonatan Waern <jonatan.waern@intel.com.
The are too many references to do this in advance, rather produce this as-needed Signed-of-by: Jonatan Waern <jonatan.waern@intel.com>
JonatanWaern
force-pushed
the
disable-register-size-check
branch
from
a077246 to
e656829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various issues related to how parameters are tracked as symbols