-
Notifications
You must be signed in to change notification settings - Fork 5
Suppress triggering device analyses and resolving imported files for single file CLI mode #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress triggering device analyses and resolving imported files for single file CLI mode #34
Conversation
|
Please give the pull request some sort of descriptive name, even if its a draft not ready for review. |
f4178e7 to
f7a1bdb
Compare
e25faec to
68d37f9
Compare
|
We have suppressed device analyses and any requests being sent from ActionContext into the main server loop. Only step 3 from issue #10 is still missing. This can be optimized further but the single file mode appears to work fast enough for now. Might be worth checking it with a set of multiple files. No imports are analyzed, but the files are still resolved by the file_management logic so the VFS must be spending some cycles on this that won't be used for anything. @JonatanWaern after doing some work on this, I believe the |
f671bd7 to
8488cf6
Compare
I have renamed this boolean to So far, both CLI mode and the interactive editor mode with the extension work fine with these changes. |
JonatanWaern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes needed, seems to work overall though.
JonatanWaern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now I think, just needs a rebase on main before merge.
67aadc2 to
4cbb5e6
Compare
a562496 to
21a0c12
Compare
Done, now rebased and tested locally. The CLI mode works as intended. |
9b37b6f to
6f082cf
Compare
6f082cf to
8d4ae01
Compare
8d4ae01 to
dba6005
Compare
This PR addresses issue #10 - Support single file linting mode that does not recurse through imported files
Signed-off-by: Juan Vasquez juan.j.vasquez.alfaro@intel.com