Skip to content

Improve warning log messages about failing optional features #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2022
Merged

Improve warning log messages about failing optional features #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29fc73a
Elaborate error message on /dev/kmsg failure
Jongy Apr 3, 2022
18d9d9e
Elaborate proc_events start error message
Jongy Apr 3, 2022
0e130a3
fix format
Jongy Apr 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions gprofiler/kernel_messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,19 @@ def on_missed(self) -> None:

def get_kernel_messages_provider() -> KernelMessagesProvider:
if DefaultKernelMessagesProvider is EmptyKernelMessagesProvider:
logger.info("Profilee error monitoring is not supported for this system.")
logger.info(
"Profilee error monitoring via kernel messages is not supported for this system"
" (this does not prevent profiling)"
)
return DefaultKernelMessagesProvider()

try:
return GProfilerKernelMessagesProvider()
except Exception:
logger.warning(
"Failed to start kernel messages listener. Profilee error monitoring not available. (Do you have permission"
" to read /dev/kmsg?)",
"Failed to start kernel messages listener. Profilee error monitoring via kernel messages"
" is not available (this does not prevent profiling). Do you have permission"
" to read /dev/kmsg?",
exc_info=True,
)
return EmptyKernelMessagesProvider()
6 changes: 5 additions & 1 deletion gprofiler/profilers/java.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,11 @@ def start(self) -> None:
try:
proc_events.register_exit_callback(self._proc_exit_callback)
except Exception:
logger.warning("Failed to enable proc_events listener for exited Java processes", exc_info=True)
logger.warning(
"Failed to enable proc_events listener for exited Java processes"
" (this does not prevent Java profiling)",
exc_info=True,
)
else:
self._enabled_proc_events = True

Expand Down