Skip to content

utils: perf: Catch another case of perf permissions error #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2022
Merged

utils: perf: Catch another case of perf permissions error #353

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f57b1ca
utils: perf: Catch another case of perf permissions error
Jongy Apr 29, 2022
e9f02b5
utils: perf: Return False on errors and log them
Jongy May 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions gprofiler/utils/perf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,11 @@
#

from gprofiler.exceptions import CalledProcessError
from gprofiler.log import get_logger_adapter
from gprofiler.utils import resource_path, run_process

logger = get_logger_adapter(__name__)


def perf_path() -> str:
return resource_path("perf")
Expand All @@ -19,12 +22,18 @@ def can_i_use_perf_events() -> bool:
run_process([perf_path(), "record", "-o", "/dev/null", "--", "/bin/true"])
except CalledProcessError as e:
# perf's output upon start error (e.g due to permissions denied error)
if e.returncode == 255 and (
b"Access to performance monitoring and observability operations is limited" in e.stderr
or b"perf_event_open(..., PERF_FLAG_FD_CLOEXEC) failed with unexpected error" in e.stderr
if not (
e.returncode == 255
and (
b"Access to performance monitoring and observability operations is limited" in e.stderr
or b"perf_event_open(..., PERF_FLAG_FD_CLOEXEC) failed with unexpected error" in e.stderr
or b"Permission error mapping pages.\n" in e.stderr
)
):
return False
raise
logger.warning(
"Unexpected perf exit code / error output, returning False for perf check anyway", exc_info=True
)
return False
else:
# all good
return True