java: Get stdout/stderr from fdtransfer #402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fdtransfer works by fork()ing, returning control to its parent while the child process waits until
async-profiler connects. The child inherits the standard stream fds, preventing subprocess's communicate
from returning when the process exits. I added close() calls and now it works.
The rationale - I'm seeing errors in
_run_fdtransferbut I'm unable to debug because all I get is:with this PR, and this small patch on fdtransfer:
I'm now getting:
so I will be able to debug real problems later on.
See commit Granulate/async-profiler@83fd518.