Colaesce process basename checks & check argv[0] as well #460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a helper
is_process_basenamewhich checks both the comm & argv[0], then fixed all relevant sites to use it.EDIT: manual tests described ahead, but I also added automatic tests for it.
To test, I applied this diff:
Before this branch:
After - process is profiled fine, and I get stacks like:
Along the way, this fixes at least one usage of
process.exe()which is problematic (should useprocess_exe()).