Added golang and node process utils #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
put these in a their own module, don't throw it in the package root |
Contributor
Author
Python and Java are also in the root folder. |
Jongy
reviewed
Sep 15, 2022
granulate_utils/node.py
Outdated
| # Licensed under the AGPL3 License. See LICENSE.md in the project root for license information. | ||
| # | ||
|
|
||
| DETECTED_NODE_PROCESSES_REGEX = r"^.+/libnode\.so" |
Contributor
There was a problem hiding this comment.
There is no such thing as libnode. Node process identification is done by /proc/pid/exe.
Contributor
Author
There was a problem hiding this comment.
Apparently it's only loaded on some versions. Changed to gProfiler's method, so now all logic is copied.
Contributor
|
See that the runtime detection code in gProfiler has gone through some changes here : |
michelhe
reviewed
Sep 19, 2022
granulate_utils/golang.py
Outdated
|
|
||
| @functools.lru_cache(maxsize=4096) | ||
| def get_process_golang_version(process: Process) -> Optional[str]: | ||
| elf_path = f"/proc/{process.pid}/exe" |
Contributor
There was a problem hiding this comment.
use granulate_utils.linux.process.process_exe
michelhe
approved these changes
Sep 19, 2022
Jongy
pushed a commit
to intel/gprofiler
that referenced
this pull request
Oct 14, 2022
This PR updates granulate-utils post the changes in intel/granulate-utils#73, and includes a few other updates from the utils repo as well, one of them is intel/granulate-utils#87 which fixes #503.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the code is copied from:
https://github.com/Granulate/gprofiler/blob/master/gprofiler/profilers/perf.py#L272
And will be used there as well.