tests: Break up application_docker_images() #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More lines-of-code for the same task, but the image generators are much more clear now. This code has become a hassle to work with, and now it's simple again :)
Jongy
commented
Sep 17, 2022
| return arg | ||
|
|
||
|
|
||
| def assert_cast(typ: Type[T], arg: Any) -> T: |
Contributor
Author
There was a problem hiding this comment.
I added it but after a refactor I won't need it. Still useful, so keeping it
Contributor
Author
|
Documented the 2 flaky issues in #462 ( |
netaneld122
approved these changes
Sep 21, 2022
|
|
||
|
|
||
| @fixture(scope="session") | ||
| def application_docker_images(docker_client: DockerClient) -> Mapping[str, Image]: |
Contributor
There was a problem hiding this comment.
Maybe not in this PR, but perhaps it might be better to build the images lazily rather than building them all in advance, because right now even if you run one specific test it will build all images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More lines-of-code for the same task, but the image generators are much more clear now. This code has become a hassle to work with, and now it's simple again :)
As said I'll do here.