Changed granulate-utils version and code rearrangement accordingly #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jongy
reviewed
Sep 22, 2022
michelhe
approved these changes
Sep 22, 2022
Contributor
|
@grariel please finish it |
Contributor
Author
It needs to be prioritized... |
Contributor
It will be. As a directive, we are not generating more code dups here. So if you move something to utils, we take the effort to update the profiler to use it as well |
Jongy
approved these changes
Oct 14, 2022
Contributor
|
I'll merge it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved some methods to granulate-utils.
See: intel/granulate-utils#73
How Has This Been Tested?
Existing automatic tests only.