Skip to content

Conversation

@mpozniak95
Copy link
Contributor

Description

Functions snapshot_one_profile and snapshot_one_collapse are replaced by snapshot_pid_profile and snapshot_one_collapse in test_java.py and test_sanity.py tests.

Related Issue

#514

Motivation and Context

How Has This Been Tested?

Run test_java and test_sanity

Screenshots

Checklist:

  • I have read the CONTRIBUTING document.
  • I have updated the relevant documentation.
  • I have added tests for new logic.

@mpozniak95 mpozniak95 requested a review from Jongy October 6, 2022 13:11
@Jongy Jongy added the tests label Oct 6, 2022
@Jongy
Copy link
Contributor

Jongy commented Oct 6, 2022

CI failure seems like somethign was broken in our dependencies and a freshly installed flake8 doesn't run - https://github.com/Granulate/gprofiler/actions/runs/3197282546/jobs/5220663090

We probably need to downgrade the version of flake8 or another library. @mpozniak95 you can check it out, otherwise I will reach it later today.

@Jongy Jongy mentioned this pull request Oct 6, 2022
@Jongy
Copy link
Contributor

Jongy commented Oct 6, 2022

@mpozniak95 you can merge from master, I solved the flake8 issue.

@mpozniak95
Copy link
Contributor Author

Merged from master

@Jongy
Copy link
Contributor

Jongy commented Oct 7, 2022

Flaky failure:

E       [2022-10-07 08:28:01,861] ERROR: gprofiler.profilers.profiler_base: JavaProfiler: failed to profile process 7 (java)
E       Traceback (most recent call last):
E         File "granulate_utils/linux/ns.py", line 248, in _switch_and_run
E         File "gprofiler/profilers/java.py", line 230, in _run_java_version
E         File "gprofiler/utils/__init__.py", line 249, in run_process
E         File "gprofiler/utils/__init__.py", line 197, in _reap_process
E         File "subprocess.py", line 863, in communicate
E         File "subprocess.py", line 1525, in _communicate
E         File "selectors.py", line 351, in register
E         File "selectors.py", line 237, in register
E         File "selectors.py", line 224, in _fileobj_lookup
E         File "selectors.py", line 39, in _fileobj_to_fd
E       ValueError: Invalid file object: <_io.BufferedReader name=11>

Merging this :)

@Jongy Jongy merged commit 18b1068 into intel:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants