lint: Upgrade flake8 #519
Merged
lint: Upgrade flake8 #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Seems to have solved the problem. I'll wait for tests to pass because this could change other dependencies as well. |
Contributor
Author
|
Flaky failure: #513 |
michelhe
approved these changes
Oct 6, 2022
Merged
Jongy
added a commit
to intel/granulate-utils
that referenced
this pull request
Oct 12, 2022
Follows intel/gprofiler#519
Jongy
added a commit
to intel/granulate-utils
that referenced
this pull request
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to solve https://github.com/Granulate/gprofiler/actions/runs/3173626903/jobs/5220214768.
I searched online for the error and got to this one: https://stackoverflow.com/a/73932581/ which matches what I suggested here. By upgrading flake8 I now see in its downloaded dependencies that it adds the necessary constraint:
Collecting importlib-metadata<4.3,>=1.1.0.