Moving requirement to handle flake8 issue to the CI instead of the requirements.txt #84
Conversation
| python -m pip install --upgrade pip | ||
| pip install -r requirements.txt | ||
| pip install -r dev-requirements.txt | ||
| pip install --force-reinstall importlib_metadata~=4.8 # Added requirement separately since it stems from an errorneous lint. See the following link for more details: https://github.com/Granulate/granulate-utils/pull/82#discussion_r985745999 |
There was a problem hiding this comment.
So why separately and not in dev-requirements? And why --force-reinstall?
There was a problem hiding this comment.
Maybe the comment wasn't clear, importlib_metadata==5 is installed as it is a requirement of 1 of the packages used by granulate-utils/gLogger. I need importlib_metadata~=4.8 so I must reinstall it in order for it to work.
It is separate from dev-requirements.yml because it should be temporary until they fix the problematic requirements in the link suggested.
There was a problem hiding this comment.
Yes, that's the same issue actually. If you manage to make it work by upgrading flake8 LMK. I'll remove the fix here
There was a problem hiding this comment.
I managed. Do the same fix here and remove the importlib_metadata thing
|
already fixed |
@tomersa - this is not fixed, you kept the |
|
I've checked it using a temp PR and all the CI tests passed: |
|
Fixed in #92 |
No description provided.