-
Notifications
You must be signed in to change notification settings - Fork 11
Add wrapper for catching FileNotFound Exception #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
11f7e4d
Catch FileNotFound exception and if it refers to /proc/ change it to …
mpozniak95 cfeff26
Change checking if /proc/ is in path
mpozniak95 f9b95bb
Rename decorator, change the way of checking if file is pid, add typing
mpozniak95 c969071
Rename decorator, change the way of checking if file is pid, add typing
mpozniak95 d5f6301
Sort imports in linux/elf.py file
mpozniak95 5d57754
Black linter issue addressed
mpozniak95 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is true though, that
pid_existsis a better check than what we have inread_proc_file- we useos.path.exists("/proc/pid"), but this will return True also ifpidis atidof another process (e.g due to reuse).pid_existsuses different means to check, to avoid this confusion. Note @d3dave .Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that in
read_proc_filewe do not want to support PIDs only. I can see value in reading a specific thread'smountinfo,ns/*,stat, etc.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, instead of
exists(/proc/pid)should have justkill(pid, 0). (Hmmm, pretty sure I copied that from psutil...)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pid_existsdoes extra checks because they claimos.killis bad as well :dumb: