Add wrapper for catching FileNotFound Exception #87
Conversation
|
@Jongy please review :) |
| pid_max = int(pid_max_file.read()) | ||
| if pid <= pid_max: | ||
| # Check if pid is running | ||
| if not psutil.pid_exists(pid): |
There was a problem hiding this comment.
It is true though, that pid_exists is a better check than what we have in read_proc_file - we use os.path.exists("/proc/pid"), but this will return True also if pid is a tid of another process (e.g due to reuse). pid_exists uses different means to check, to avoid this confusion. Note @d3dave .
There was a problem hiding this comment.
I assume that in read_proc_file we do not want to support PIDs only. I can see value in reading a specific thread's mountinfo, ns/*, stat, etc.
There was a problem hiding this comment.
Also, instead of exists(/proc/pid) should have just kill(pid, 0). (Hmmm, pretty sure I copied that from psutil...)
There was a problem hiding this comment.
pid_exists does extra checks because they claim os.kill is bad as well :dumb:
Jongy
left a comment
Jongy
left a comment
There was a problem hiding this comment.
1 more question, and fix linters :)
|
Btw, did you verify that mypy accepts the typing tricks for the decorator? (i.e that |
|
|
Looks good! |
This PR updates granulate-utils post the changes in intel/granulate-utils#73, and includes a few other updates from the utils repo as well, one of them is intel/granulate-utils#87 which fixes #503.
3 participants
It wraps function get_elf_id(), if that function throws FileNotFound exception then wrapper checks if not found file is /proc/{pid}/*, if it is, wrapper changes exception to NoSuchProcess.
Connected to: intel/gprofiler#503