[Transform] Hoist thread-local allocator within the nested parallel loops #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ijie/mem-merge
…ijie/mem-merge
…ijie/mem-merge
…ijie/mem-merge
…ijie/mem-merge
Menooker
reviewed
Sep 13, 2024
Menooker
reviewed
Sep 13, 2024
Menooker
reviewed
Sep 13, 2024
Menooker
reviewed
Sep 13, 2024
| isa<arith::ConstantIndexOp>(ub.getDefiningOp())); | ||
| }); | ||
|
|
||
| isStatic &= llvm::all_of(lowerBounds, [](Value &lb) { |
There was a problem hiding this comment.
shall we also check the step? I am also not sure if &= will short-cut the evaluation of llvm::all_of(...) if isStatic is false.
Contributor
Author
There was a problem hiding this comment.
Yes, I can add the check for the step, and use early return when the expression return false.
Menooker
reviewed
Sep 13, 2024
Menooker
reviewed
Sep 13, 2024
Menooker
reviewed
Sep 13, 2024
Menooker
approved these changes
Sep 18, 2024
Yun-Fly
reviewed
Sep 20, 2024
Yun-Fly
approved these changes
Sep 20, 2024
Yun-Fly
reviewed
Sep 20, 2024
zhczhong
reviewed
Sep 20, 2024
zhczhong
reviewed
Sep 23, 2024
zhczhong
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to track #120
This is another implementation of hoisting thread-local allocator base on the new memref-merge design, so it depends on #44