log_i2c: Add !LOG_MODE_MINIMAL dependency for i2c log backend #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It cannot be enabled when LOG_MODE_MINIMAL is set. Signed-off-by: Dong Wang <dong.d.wang@intel.com>
kwd-doodling
requested review from
lifenggitacc and
likongintel
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds a dependency to prevent the I2C log backend from being enabled when LOG_MODE_MINIMAL is set, addressing a configuration incompatibility issue.
- Updated conditional guard to exclude LOG_MODE_MINIMAL from I2C logging backend configuration
- Updated corresponding endif comment to match the new conditional logic
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
likongintel
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It cannot be enabled when LOG_MODE_MINIMAL is set.