This repository was archived by the owner on Jan 28, 2023. It is now read-only.
Conversation
This reverts commit 5cfb841. The said patch is seriously flawed: 1. It calls the wrong Windows Driver Kit functions. E.g., KeAcquireInStackQueuedSpinLockAtDpcLevel() should only be called when IRQL = DISPATCH_LEVEL, but most of HAXM code runs below that level. The more general KeAcquireInStackQueuedSpinLock() should be used instead. 2. Unlike the release of a regular spin lock, which is a simple operation, the release of a queued spin lock needs to wait for a condition and thus may block. If called from a function that should never block, e.g. ept_tree_alloc_page(), a deadlock may occur. Fall back to regular spin locks which do not block on release.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 5cfb841.
The said patch is seriously flawed:
KeAcquireInStackQueuedSpinLockAtDpcLevel() should only be called
when IRQL = DISPATCH_LEVEL, but most of HAXM code runs below
that level. The more general KeAcquireInStackQueuedSpinLock()
should be used instead.
operation, the release of a queued spin lock needs to wait for a
condition and thus may block. If called from a function that
should never block, e.g. ept_tree_alloc_page(), a deadlock may
occur.
Fall back to regular spin locks which do not block on release.