jenkins: Add initial jenkinsfile #189
Conversation
chuyd
force-pushed
the
jenkinsfile
branch
14 times, most recently
from
0c09537 to
a47b025
Compare
chuyd
changed the title
Jenkinsfile
Outdated
| } | ||
| } | ||
| } | ||
| stage("make intel-fpga-admissionwebhook") { |
There was a problem hiding this comment.
This is practically useless. stage("make"){} already has built everything.
There was a problem hiding this comment.
Changes made, thanks for the review
Jenkinsfile
Outdated
| } | ||
| } | ||
| } | ||
| stage("make images with buildah") { |
There was a problem hiding this comment.
images without buildah are not built.
Also, use parallel stages for building something in variations (e.g. images with docker and images with buildah)
https://jenkins.io/blog/2017/09/25/declarative-1/
There was a problem hiding this comment.
Changes made, thanks for the review
chuyd
force-pushed
the
jenkinsfile
branch
2 times, most recently
from
b7e6cd1 to
8e870a4
Compare
|
Can you please evaluate if several of stages can be done in parallel? |
Jenkinsfile
Outdated
| } | ||
| stage('make plugins') { | ||
| parallel { | ||
| stage("make intel-fpga-admissionwebhook") { |
There was a problem hiding this comment.
So, in practice, those "make intel-*" targets are parts of the "make images" target, and in practice we are building all images at least twice with this pipeline. Can we improve that please?
chuyd
force-pushed
the
jenkinsfile
branch
5 times, most recently
from
4e905e6 to
748b873
Compare
|
@chuyd why it's crashing? no memory/disk space in the VM or something else? |
I was suspecting the same, I doubled the memory/disk resources in the last run a few hours ago and it failed on other different make target of the same stage |
chuyd
force-pushed
the
jenkinsfile
branch
3 times, most recently
from
0a528e2 to
836501b
Compare
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
=======================================
Coverage 79.18% 79.18%
=======================================
Files 11 11
Lines 1494 1494
=======================================
Hits 1183 1183
Misses 279 279
Partials 32 32Continue to review full report at Codecov.
|
This Jenkinsfile provides basic CI based on the .travis.yml which ports the travis behaviour to Jenkins by checking the following make targets functionallity: - make format - make lint - make vet - make cyclomatic-check - make test - make images - make images BUILDER=buildah - make demos - make demos BUILDER=buildah The main intention of this commit is to provide an starting point where anybody can improve the coverage at anytime and get PR cheks on Jenkins.
…c+gRPC-plugin ci-build: add rules to install protoc and gRPC plugin.
3 participants
This Jenkinsfile provides basic CI based on the .travis.yml
which ports the travis behaviour to Jenkins by checking the
following make targets:
The main intention of this commit is to provide an starting point
where anybody can improve the coverage at anytime and get PR cheks
on Jenkins.