New base images and QAT DPDK testing #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Testing: TBD |
Contributor
Author
|
buildah is not happy using an arg variable with FROM: |
mythi
commented
Aug 7, 2019
| @@ -0,0 +1,5 @@ | |||
| nameSuffix: -crypto-perf | |||
| bases: | |||
| - ../dpdk-test/ | |||
Contributor
Author
There was a problem hiding this comment.
I slept overnight and decided to move dpdk-test, crypto-perf and compress-perf to a dir called patches/ to indicate the overlays are not usable as is.
Contributor
Author
buildah v1.5 should fix it. I'll update Jenkinsfile/travis. |
mythi
force-pushed
the
dockerfile-update
branch
4 times, most recently
from
fa233ef to
c8f004e
Compare
mythi
force-pushed
the
dockerfile-update
branch
from
c8f004e to
69a21c5
Compare
Contributor
Author
|
@kad I've added a note about kubernetes v1.14 "dependency" with kustomize. CI errors seem real and it's because |
Contributor
|
@mythi I noticed that too. I have a minimal Building that image fails with the error: |
Contributor
|
I went to submit a bug but there already were several: clearlinux/swupd-client#1068 |
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
=======================================
Coverage 79.17% 79.17%
=======================================
Files 11 11
Lines 1508 1508
=======================================
Hits 1194 1194
Misses 281 281
Partials 33 33Continue to review full report at Codecov.
|
mythi
force-pushed
the
dockerfile-update
branch
2 times, most recently
from
46eaa23 to
37b08a5
Compare
mythi
changed the title
mythi
force-pushed
the
dockerfile-update
branch
from
37b08a5 to
53d1ba0
Compare
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
mythi
force-pushed
the
dockerfile-update
branch
2 times, most recently
from
7bd838a to
bec01f6
Compare
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
mythi
force-pushed
the
dockerfile-update
branch
from
bec01f6 to
875b08e
Compare
The modifications also bring enablers to "reproducible" builds. Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Switch to clearlinux based image and rootfs and add enablers to make builds reproducible. Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
We plan to use crypto-perf for simple QAT testing. This commit adds kustomization to make the deployment easier. The original .yaml is also moved to deployments/ with some changes. For instance, it turns out also vfio-pci mode with DPDK needs CAP_SYS_ADMIN (See PR: intel#187 which states that only igb_uio would need it). kustomize is available part of kubectl since kubernetes v1.14. Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Clear Linux enables DPDK QAT PMD so we can move to use everything from
there. This saves maintenance efforts and we get more up-to-date DPDK.
The DPDK version in this update gives a tool for compress perf too, for
instance.
The commit also adds kustomize scripts that overlay the original DPDK
demo deployment to run dpdk-test-[compress|crypto|-perf test cases:
$ kubectl apply -k deployments/qat_dpdk_app/test-compress1/
$ kubectl apply -f deployments/qat_dpdk_app/test-crypto1/
New test cases ('ptest's with varying parameters) can be easily added
by following the pattern in test-[crypto|compress]1 directories.
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
mythi
force-pushed
the
dockerfile-update
branch
from
875b08e to
e1399b5
Compare
Contributor
Author
|
@kad from my side this is ready |
Contributor
Author
Contributor
|
LGTM |
askervin
pushed a commit
to askervin/intel-device-plugins-for-kubernetes
that referenced
this pull request
May 6, 2020
…ainer resource-manager: free any lingering instance upon pod/container recreation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.