Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Conversation

@DDEle
Copy link
Contributor

@DDEle DDEle commented Nov 15, 2023

Type of Change: Feature

API not changed

Description

  • Add PPL script
  • Add cal_diff.py script for future CI @zhenwei-intel
  • Fix UT (test_llm_runtime.py)

Expected Behavior & Potential Risk

N/A

How has this PR been tested?

Internal extension test:

Dependency Change?

No

@DDEle DDEle marked this pull request as draft November 15, 2023 06:00
Copy link
Contributor

@airMeng airMeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a note on homepage readme

@zhenwei-intel
Copy link
Contributor

Do we have PPL data of pytorch and that of cpp graph fp32/int4?

@DDEle DDEle force-pushed the graph-ppl branch 2 times, most recently from 856b6cd to 9e30626 Compare November 15, 2023 14:27
@DDEle
Copy link
Contributor Author

DDEle commented Nov 16, 2023

Do we have PPL data of pytorch and that of cpp graph fp32/int4?

image
https://inteltf-jenk.sh.intel.com/job/ITREX-cpp-graph-extension-WIP/32/artifact/report.html

@DDEle DDEle marked this pull request as ready for review November 16, 2023 06:18
@DDEle
Copy link
Contributor Author

DDEle commented Nov 16, 2023

gpt-neox-20b and opt-1.3b checked in this internal extension test: https://inteltf-jenk.sh.intel.com/job/ITREX-cpp-graph-extension-WIP/33/artifact/report.html

Copy link
Contributor

@a32543254 a32543254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DDEle and others added 8 commits November 17, 2023 15:29
Signed-off-by: zhenwei-intel <zhenwei.liu@intel.com>
Signed-off-by: zhenwei-intel <zhenwei.liu@intel.com>
Signed-off-by: zhenwei-intel <zhenwei.liu@intel.com>
Signed-off-by: zhenwei-intel <zhenwei.liu@intel.com>
DDEle and others added 3 commits November 17, 2023 15:29
Copy link
Contributor

@hshen14 hshen14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose to introduce ppl script here? Can we just reuse lm-eval-harness to measure the ppl?

@DDEle
Copy link
Contributor Author

DDEle commented Nov 20, 2023

What's the purpose to introduce ppl script here? Can we just reuse lm-eval-harness to measure the ppl?

It is for internal usage of LLM Runtime to keep track of the inference accuracy with minimal test time addition. It also works as a usage example of the LLM Runtime (llama.cpp also has a ppl script in its examples directory). We will investigate lm-eval-harness and see if it can help.

@VincyZhang VincyZhang merged commit df40d5e into main Nov 20, 2023
@VincyZhang VincyZhang deleted the graph-ppl branch November 20, 2023 01:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants