This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Move IMAGE_DSK_BASE variable to correct place #173
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jussi Laako <jussi.laako@linux.intel.com>
pohly
reviewed
Jun 6, 2017
Contributor
pohly
left a comment
pohly
left a comment
There was a problem hiding this comment.
What problem does this fix?
I suspect it addresses the use of image-dsk.bbclass via the "dsk" IMAGE_FSTYPES, right?
This isn't getting tested anymore and thus the incorrect declaration of IMAGE_DSK_BASE also wasn't found.
IMHO instead of fixing IMAGE_DSK_BASE and the "dsk" IMAGE_FSTYPES, we should remove the entire dead code.
Contributor
|
On Tue, Jun 6, 2017 at 8:47 PM, Patrick Ohly wrote:
IMHO instead of fixing IMAGE_DSK_BASE and the "dsk" IMAGE_FSTYPES, we
should remove the entire dead code.
I agree. I had intentionally postponed the removal but if it's not working
anymore with the new layer setup, it's time to do it.
FWIW, I also noticed today we can drop image_types_extra.bbclass too...
|
Contributor
Author
|
Well, it does work with this fix. I'm testing it daily... |
Contributor
|
@jlaako please prepare to move to the refkit default image format (.wic) as .dsk is EOL. |
Contributor
|
obsoleted by #187 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jussi Laako jussi.laako@linux.intel.com