This repository was archived by the owner on Aug 5, 2022. It is now read-only.
append: fix _append rules where there is no whitespace after " #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"git grep '_append.*=\ \"[^ \\]' meta-refkit*" reports no findings. Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
ipuustin
reviewed
Jun 12, 2017
|
|
||
| # Enable emergency shell in initramfs-framework. | ||
| APPEND_append = "${@ ' init_fatal_sh' if (d.getVar('IMAGE_MODE') or '') == 'development' else ''}" | ||
| APPEND_append = " ${@ ' init_fatal_sh' if (d.getVar('IMAGE_MODE') or '') == 'development' else ''}" |
Contributor
There was a problem hiding this comment.
This is not a bug... the space is becore init_fatal_sh.
ipuustin
reviewed
Jun 12, 2017
|
|
||
| # Enable/disable IMA also in per-image boot parameters. | ||
| APPEND_append = "${@bb.utils.contains('IMAGE_FEATURES', 'ima', ' rootflags=i_version', ' no-ima', d)}" | ||
| APPEND_append = " ${@bb.utils.contains('IMAGE_FEATURES', 'ima', ' rootflags=i_version', ' no-ima', d)}" |
ipuustin
reviewed
Jun 12, 2017
| # The Edison BSP does not support APPEND, some other solution is needed | ||
| # for that machine. | ||
| APPEND_append = "${@bb.utils.contains('IMAGE_FEATURES', 'smack', '', ' security=none', d)}" | ||
| APPEND_append = " ${@bb.utils.contains('IMAGE_FEATURES', 'smack', '', ' security=none', d)}" |
Contributor
There was a problem hiding this comment.
Not a bug. Do we have smack anyway? And what is this talk about Edison BSP?
ipuustin
reviewed
Jun 12, 2017
| # Activate support for updating EFI system partition when using | ||
| # both meta-swupd and the EFI kernel+initramfs combo. | ||
| IMAGE_INSTALL_append = "${@ ' efi-combo-trigger' if oe.types.boolean(d.getVar('REFKIT_USE_DSK_IMAGES') or '0') else '' }" | ||
| IMAGE_INSTALL_append = " ${@ ' efi-combo-trigger' if oe.types.boolean(d.getVar('REFKIT_USE_DSK_IMAGES') or '0') else '' }" |
ipuustin
reviewed
Jun 12, 2017
| # default for all packages), then we can use ROOTFS_POSTINSTALL_COMMAND | ||
| # again. | ||
| ROOTFS_POSTUNINSTALL_COMMAND_append = "stateless_mangle_rootfs;" | ||
| ROOTFS_POSTUNINSTALL_COMMAND_append = " stateless_mangle_rootfs;" |
Contributor
There was a problem hiding this comment.
Likely not a bug, since the list appears to be separated by ;.
ipuustin
reviewed
Jun 12, 2017
| require recipes-core/ovmf/ovmf-shell-image.bb | ||
|
|
||
| WKS_SEARCH_PATH_append = ":${COREBASE}/meta/recipes-core/ovmf" | ||
| WKS_SEARCH_PATH_append = " :${COREBASE}/meta/recipes-core/ovmf" |
Contributor
There was a problem hiding this comment.
Not a bug -- PATH items are separated by :.
Contributor
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"git grep '_append.=\ "[^ \\]' meta-refkit" reports no findings.
Signed-off-by: Tuomas Katila tuomas.katila@intel.com