-
Notifications
You must be signed in to change notification settings - Fork 54
append: fix _append rules where there is no whitespace after " #180
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -123,8 +123,8 @@ REFKIT_DM_VERITY_PARTITION () { | |
| part --source dm-verity --uuid ${REFKIT_DM_VERITY_PARTUUID} --label rootfs | ||
| } | ||
| REFKIT_EXTRA_PARTITION .= "${@ bb.utils.contains('IMAGE_FEATURES', 'dm-verity', d.getVar('REFKIT_DM_VERITY_PARTITION'), '', d) }" | ||
| APPEND_append = "${@ bb.utils.contains('IMAGE_FEATURES', 'dm-verity', ' dmverity=PARTUUID=${REFKIT_DM_VERITY_PARTUUID}', '', d) }" | ||
| WICVARS_append = "${@ bb.utils.contains('IMAGE_FEATURES', 'dm-verity', ' \ | ||
| APPEND_append = " ${@ bb.utils.contains('IMAGE_FEATURES', 'dm-verity', ' dmverity=PARTUUID=${REFKIT_DM_VERITY_PARTUUID}', '', d) }" | ||
| WICVARS_append = " ${@ bb.utils.contains('IMAGE_FEATURES', 'dm-verity', ' \ | ||
| REFKIT_DMVERITY_PRIVATE_KEY \ | ||
| REFKIT_DMVERITY_PRIVATE_KEY_HASH \ | ||
| REFKIT_DMVERITY_PASSWORD \ | ||
|
|
@@ -273,7 +273,7 @@ INITRD_IMAGE_intel-corei7-64 = "${REFKIT_INITRAMFS}" | |
| INITRD_IMAGE_intel-quark = "${REFKIT_INITRAMFS}" | ||
|
|
||
| # Enable emergency shell in initramfs-framework. | ||
| APPEND_append = "${@ ' init_fatal_sh' if (d.getVar('IMAGE_MODE') or '') == 'development' else ''}" | ||
| APPEND_append = " ${@ ' init_fatal_sh' if (d.getVar('IMAGE_MODE') or '') == 'development' else ''}" | ||
|
|
||
| # The expected disk layout is not compatible with the HDD format: | ||
| # HDD places the rootfs as loop file in a VFAT partition (UEFI), | ||
|
|
@@ -290,7 +290,7 @@ REMOVABLE_MEDIA_ROOTFS_PARTUUID_VALUE = "12345678-9abc-def0-0fed-cba987654321" | |
| INT_STORAGE_ROOTFS_PARTUUID_VALUE = "12345678-9abc-def0-0fed-cba987654320" | ||
|
|
||
| # Enable/disable IMA also in per-image boot parameters. | ||
| APPEND_append = "${@bb.utils.contains('IMAGE_FEATURES', 'ima', ' rootflags=i_version', ' no-ima', d)}" | ||
| APPEND_append = " ${@bb.utils.contains('IMAGE_FEATURES', 'ima', ' rootflags=i_version', ' no-ima', d)}" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a bug. |
||
|
|
||
| # Conditionally include the class only if distro features indicate that | ||
| # integrity support is enabled. We cannot include unconditionally | ||
|
|
@@ -318,7 +318,7 @@ ima_evm_sign_rootfs_prepend () { | |
| # | ||
| # The Edison BSP does not support APPEND, some other solution is needed | ||
| # for that machine. | ||
| APPEND_append = "${@bb.utils.contains('IMAGE_FEATURES', 'smack', '', ' security=none', d)}" | ||
| APPEND_append = " ${@bb.utils.contains('IMAGE_FEATURES', 'smack', '', ' security=none', d)}" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a bug. Do we have |
||
|
|
||
| # Use what RMC gives, not the defaults in meta-intel machine configs | ||
| APPEND_remove_intel-corei7-64 = "console=ttyS0,115200" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ inherit swupd-image | |
|
|
||
| # Activate support for updating EFI system partition when using | ||
| # both meta-swupd and the EFI kernel+initramfs combo. | ||
| IMAGE_INSTALL_append = "${@ ' efi-combo-trigger' if oe.types.boolean(d.getVar('REFKIT_USE_DSK_IMAGES') or '0') else '' }" | ||
| IMAGE_INSTALL_append = " ${@ ' efi-combo-trigger' if oe.types.boolean(d.getVar('REFKIT_USE_DSK_IMAGES') or '0') else '' }" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a bug. |
||
|
|
||
| # Workaround when both Smack and swupd are used: | ||
| # Setting a label explicitly on the directory prevents it | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -252,7 +252,7 @@ python () { | |
| # all /etc files are marked as CONFFILES (perhaps by adding that as | ||
| # default for all packages), then we can use ROOTFS_POSTINSTALL_COMMAND | ||
| # again. | ||
| ROOTFS_POSTUNINSTALL_COMMAND_append = "stateless_mangle_rootfs;" | ||
| ROOTFS_POSTUNINSTALL_COMMAND_append = " stateless_mangle_rootfs;" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Likely not a bug, since the list appears to be separated by |
||
|
|
||
| python stateless_mangle_rootfs () { | ||
| pn = d.getVar('PN', True) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| require recipes-core/ovmf/ovmf-shell-image.bb | ||
|
|
||
| WKS_SEARCH_PATH_append = ":${COREBASE}/meta/recipes-core/ovmf" | ||
| WKS_SEARCH_PATH_append = " :${COREBASE}/meta/recipes-core/ovmf" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a bug -- PATH items are separated by |
||
|
|
||
| QB_DRIVE_TYPE = "/dev/vd" | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a bug... the space is becore
init_fatal_sh.