Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ REFKIT_IMAGE_COMPUTERVISION_EXTRA_FEATURES += "${@ '' if (d.getVar('IMAGE_MODE')
# Example for customization in local.conf when building
# refkit-image-computervision.bb:
# IMAGE_BASENAME_pn-refkit-image-computervision = "my-refkit-image-reference"
# REFKIT_IMAGE_COMPUTERVISION_EXTRA_INSTALL_append = "my-own-package"
# REFKIT_IMAGE_COMPUTERVISION_EXTRA_FEATURES_append = "dev-pkgs"
# REFKIT_IMAGE_COMPUTERVISION_EXTRA_INSTALL_append = " my-own-package"
# REFKIT_IMAGE_COMPUTERVISION_EXTRA_FEATURES_append = " dev-pkgs"

inherit refkit-image
2 changes: 1 addition & 1 deletion meta-refkit-core/classes/image-dsk.bbclass
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ IMAGE_DEPENDS_dsk += " \
# when adding swupd bundle support, because there virtual images
# without active .dsk are used to generate the rootfs for other
# images with .dsk format.
INITRD_LIVE_append = "${@ ('${DEPLOY_DIR_IMAGE}/' + d.getVar('INITRD_IMAGE', expand=True) + '-${MACHINE}.cpio.gz') if d.getVar('INITRD_IMAGE', True) else ''}"
INITRD_LIVE_append = " ${@ ('${DEPLOY_DIR_IMAGE}/' + d.getVar('INITRD_IMAGE', expand=True) + '-${MACHINE}.cpio.gz') if d.getVar('INITRD_IMAGE', True) else ''}"

PACKAGES = " "
EXCLUDE_FROM_WORLD = "1"
Expand Down
10 changes: 5 additions & 5 deletions meta-refkit-core/classes/refkit-image.bbclass
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ REFKIT_DM_VERITY_PARTITION () {
part --source dm-verity --uuid ${REFKIT_DM_VERITY_PARTUUID} --label rootfs
}
REFKIT_EXTRA_PARTITION .= "${@ bb.utils.contains('IMAGE_FEATURES', 'dm-verity', d.getVar('REFKIT_DM_VERITY_PARTITION'), '', d) }"
APPEND_append = "${@ bb.utils.contains('IMAGE_FEATURES', 'dm-verity', ' dmverity=PARTUUID=${REFKIT_DM_VERITY_PARTUUID}', '', d) }"
WICVARS_append = "${@ bb.utils.contains('IMAGE_FEATURES', 'dm-verity', ' \
APPEND_append = " ${@ bb.utils.contains('IMAGE_FEATURES', 'dm-verity', ' dmverity=PARTUUID=${REFKIT_DM_VERITY_PARTUUID}', '', d) }"
WICVARS_append = " ${@ bb.utils.contains('IMAGE_FEATURES', 'dm-verity', ' \
REFKIT_DMVERITY_PRIVATE_KEY \
REFKIT_DMVERITY_PRIVATE_KEY_HASH \
REFKIT_DMVERITY_PASSWORD \
Expand Down Expand Up @@ -273,7 +273,7 @@ INITRD_IMAGE_intel-corei7-64 = "${REFKIT_INITRAMFS}"
INITRD_IMAGE_intel-quark = "${REFKIT_INITRAMFS}"

# Enable emergency shell in initramfs-framework.
APPEND_append = "${@ ' init_fatal_sh' if (d.getVar('IMAGE_MODE') or '') == 'development' else ''}"
APPEND_append = " ${@ ' init_fatal_sh' if (d.getVar('IMAGE_MODE') or '') == 'development' else ''}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a bug... the space is becore init_fatal_sh.


# The expected disk layout is not compatible with the HDD format:
# HDD places the rootfs as loop file in a VFAT partition (UEFI),
Expand All @@ -290,7 +290,7 @@ REMOVABLE_MEDIA_ROOTFS_PARTUUID_VALUE = "12345678-9abc-def0-0fed-cba987654321"
INT_STORAGE_ROOTFS_PARTUUID_VALUE = "12345678-9abc-def0-0fed-cba987654320"

# Enable/disable IMA also in per-image boot parameters.
APPEND_append = "${@bb.utils.contains('IMAGE_FEATURES', 'ima', ' rootflags=i_version', ' no-ima', d)}"
APPEND_append = " ${@bb.utils.contains('IMAGE_FEATURES', 'ima', ' rootflags=i_version', ' no-ima', d)}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bug.


# Conditionally include the class only if distro features indicate that
# integrity support is enabled. We cannot include unconditionally
Expand Down Expand Up @@ -318,7 +318,7 @@ ima_evm_sign_rootfs_prepend () {
#
# The Edison BSP does not support APPEND, some other solution is needed
# for that machine.
APPEND_append = "${@bb.utils.contains('IMAGE_FEATURES', 'smack', '', ' security=none', d)}"
APPEND_append = " ${@bb.utils.contains('IMAGE_FEATURES', 'smack', '', ' security=none', d)}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bug. Do we have smack anyway? And what is this talk about Edison BSP?


# Use what RMC gives, not the defaults in meta-intel machine configs
APPEND_remove_intel-corei7-64 = "console=ttyS0,115200"
Expand Down
2 changes: 1 addition & 1 deletion meta-refkit-core/classes/refkit-swupd-image.bbclass
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ inherit swupd-image

# Activate support for updating EFI system partition when using
# both meta-swupd and the EFI kernel+initramfs combo.
IMAGE_INSTALL_append = "${@ ' efi-combo-trigger' if oe.types.boolean(d.getVar('REFKIT_USE_DSK_IMAGES') or '0') else '' }"
IMAGE_INSTALL_append = " ${@ ' efi-combo-trigger' if oe.types.boolean(d.getVar('REFKIT_USE_DSK_IMAGES') or '0') else '' }"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bug.


# Workaround when both Smack and swupd are used:
# Setting a label explicitly on the directory prevents it
Expand Down
2 changes: 1 addition & 1 deletion meta-refkit-core/classes/stateless.bbclass
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ python () {
# all /etc files are marked as CONFFILES (perhaps by adding that as
# default for all packages), then we can use ROOTFS_POSTINSTALL_COMMAND
# again.
ROOTFS_POSTUNINSTALL_COMMAND_append = "stateless_mangle_rootfs;"
ROOTFS_POSTUNINSTALL_COMMAND_append = " stateless_mangle_rootfs;"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely not a bug, since the list appears to be separated by ;.


python stateless_mangle_rootfs () {
pn = d.getVar('PN', True)
Expand Down
2 changes: 1 addition & 1 deletion meta-refkit-core/conf/distro/include/refkit-config.inc
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ BAD_RECOMMENDATIONS_append_refkit-config = " bluez5-client"
# Prefer systemd way of creating getty@.service symlinks using
# systemd-getty-generator (instead of the Yocto default
# systemd-serialgetty that creates everything in do_install).
PACKAGECONFIG_append_pn-systemd_refkit-config = "serial-getty-generator"
PACKAGECONFIG_append_pn-systemd_refkit-config = " serial-getty-generator"

# OE-core 7355a3c4f665e066925ea6327ac72365ab1f2f39 added a PACKAGECONFIG
# to configure cairo/python3-cairo and enabled it by default. It used to
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ RRECOMMENDS_avahi-daemon_remove_libc-glibc_refkit-config = " libnss-mdns"
RRECOMMENDS_${PN}_remove_libc-glibc_refkit-config = " libnss-mdns"

# provide libdns_sd.so and dns_sd.h header
EXTRA_OECONF_append_refkit-config = "--enable-compat-libdns_sd"
EXTRA_OECONF_append_refkit-config = " --enable-compat-libdns_sd"

FILES_${PN}_append_refkit-config = " \
${libdir}/libdns_sd.* \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ DEPENDS_remove_refkit-config = "libusb"
# split bluetoothctl into a subpackage
PACKAGES_prepend_refkit-config = "${PN}-client "
FILES_${PN}-client = "${@bb.utils.contains('PACKAGECONFIG', 'readline', '${bindir}/bluetoothctl', '', d)}"
RRECOMMENDS_${PN}_append_refkit-config += "${PN}-client"
RRECOMMENDS_${PN}_append_refkit-config = " ${PN}-client"
4 changes: 2 additions & 2 deletions meta-refkit-core/recipes-images/images/refkit-image-common.bb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ REFKIT_IMAGE_EXTRA_INSTALL += "${REFKIT_IMAGE_COMMON_EXTRA_INSTALL}"
#
# Example for customization in local.conf when building refkit-image-common.bb:
# IMAGE_BASENAME_pn-refkit-image-common = "my-refkit-image-reference"
# REFKIT_IMAGE_COMMON_EXTRA_INSTALL_append = "my-own-package"
# REFKIT_IMAGE_COMMON_EXTRA_FEATURES_append = "dev-pkgs"
# REFKIT_IMAGE_COMMON_EXTRA_INSTALL_append = " my-own-package"
# REFKIT_IMAGE_COMMON_EXTRA_FEATURES_append = " dev-pkgs"

inherit refkit-image
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ REFKIT_IMAGE_GATEWAY_EXTRA_FEATURES_append = " iotivity nodejs-runtime bluetooth
# Example for customization in local.conf when building
# refkit-image-gateway.bb:
# IMAGE_BASENAME_pn-refkit-image-gateway = "my-refkit-image-gateway"
# REFKIT_IMAGE_GATEWAY_EXTRA_INSTALL_append = "my-own-package"
# REFKIT_IMAGE_GATEWAY_EXTRA_FEATURES_append = "dev-pkgs"
# REFKIT_IMAGE_GATEWAY_EXTRA_INSTALL_append = " my-own-package"
# REFKIT_IMAGE_GATEWAY_EXTRA_FEATURES_append = " dev-pkgs"

inherit refkit-image
2 changes: 1 addition & 1 deletion meta-refkit/lib/oeqa/selftest/refkit-poky.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ def test_common_poky_config(self):

# We need an image that we can log into, so zap the root password.
self.append_config('''
REFKIT_IMAGE_EXTRA_FEATURES_append = "empty-root-password"
REFKIT_IMAGE_EXTRA_FEATURES_append = " empty-root-password"
''')
bitbake('refkit-image-common')
with runqemu('refkit-image-common',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require recipes-core/ovmf/ovmf-shell-image.bb

WKS_SEARCH_PATH_append = ":${COREBASE}/meta/recipes-core/ovmf"
WKS_SEARCH_PATH_append = " :${COREBASE}/meta/recipes-core/ovmf"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bug -- PATH items are separated by :.


QB_DRIVE_TYPE = "/dev/vd"

Expand Down