Less verbose auto-update-translator-cid #2551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
leshikus
approved these changes
Oct 24, 2024
Contributor
leshikus
left a comment
leshikus
left a comment
There was a problem hiding this comment.
I wonder if testing all commit ids is really needed; we only need to find the last one which is good enough
Contributor
Author
Sometimes the latest commit from main does not work for us for different reasons, for example a newer llvm is required, so we need to descend from latest commit to the pinned one to find the good one. Ideally it should be a binary search, but it is out of the scope of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2302.