Don't rename the already registered PCI-device

[jwrdegoede]

Devices must not be renamed after they have already been added to the device hierarchy.

dev_set_name() MUST only be called before dev_add() and the pci_dev passed to ipu_pci_probe() has been added long before ipu_pci_probe() runs, so it must not rename it.

Renaming it is confusing udevd which now all of a sudden sees a device it already knows about change name.

This is causing udev rules to not work properly with the ipu6-driver. Drop the clearly wrong dev_set_name() call.

[hao-yao]

Hi @jwrdegoede ,

Would you mind adding this change to your commit?

diff --git a/drivers/media/pci/intel/ipu.c b/drivers/media/pci/intel/ipu.c
index c9968fd38..1bd8f4dd7 100644
--- a/drivers/media/pci/intel/ipu.c
+++ b/drivers/media/pci/intel/ipu.c
@@ -299,7 +299,7 @@ static int ipu_init_debugfs(struct ipu_device *isp)
        struct dentry *file;
        struct dentry *dir;
 
-       dir = debugfs_create_dir(pci_name(isp->pdev), NULL);
+       dir = debugfs_create_dir(IPU_NAME, NULL);
        if (!dir)
                return -ENOMEM;

[jwrdegoede]

Hi @jwrdegoede ,

Would you mind adding this change to your commit?

diff --git a/drivers/media/pci/intel/ipu.c b/drivers/media/pci/intel/ipu.c
index c9968fd38..1bd8f4dd7 100644
--- a/drivers/media/pci/intel/ipu.c
+++ b/drivers/media/pci/intel/ipu.c
@@ -299,7 +299,7 @@ static int ipu_init_debugfs(struct ipu_device *isp)
        struct dentry *file;
        struct dentry *dir;
 
-       dir = debugfs_create_dir(pci_name(isp->pdev), NULL);
+       dir = debugfs_create_dir(IPU_NAME, NULL);
        if (!dir)
                return -ENOMEM;

Done, good catch.

Note this changes the debugfs dir-name from "intel-ipu" to "intel-ipu6" though. Let me know if that is undesirable and I'll change IPU_NAME to "intel-ipu".

[hao-yao]

Note this changes the debugfs dir-name from "intel-ipu" to "intel-ipu6" though. Let me know if that is undesirable and I'll change IPU_NAME to "intel-ipu".

After we removed the set_dev_name, debugfs dir is the only affected part. We finally decided to change that to IPU_NAME ("intel-ipu6"), which is clearer, instead of "intel-ipu". So now this patch is exactly we need. Thanks @jwrdegoede !