This repository was archived by the owner on Sep 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Kubernetes Power Manager v2.3.0 release #54
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: acpi-integration * shared field added to power profiles * Manager now outputs available governors and epp feature status * Test helper functions set up for creating a dummy file system side effects of change are that an EPP of "power" no longer signifies a shared pool validated through new unit tests and deploying the manager with acpi. * fix: accounting for blank governor values adds check for empty string governor
* test: Testing groundwork * Creates coverage target in makefile * creates client and manager structs to be used in future tests * test: Powernode and powerprofile tests Adds tests for powerprofile and powernode to increase code coverage
* test: Adds unit tests for time of day and powerworkload - unit tests added for time of day controllers - unit tests added for powerwrokload controller - second field added to time of day to allow shorter test times * chore: Adressing comments * adds comment describing regex pattern * removes goto statement
* test: Adds unit tests for powenode, powerpod and uncore increases code coverage for powernode, powerpod and uncore * chore: Adressing comments * adds newline between vars and functions * adds comment above each function
- removes invalid characters from node names - removes invalid time formats from timeofday fuzz
* feat: Time of day label filtering * Allows time of day to tune based on pod label * shares pod state between powerpod and TOD * feat: pod alteration detection * powernode polls for pods in the wrong pool * annotations added to ensure altered pods stay in correct pool * fix: addressing comments * go fmt run * orphaned pods moved to reconciler * for loop relegated to function * replace error checks with single line * other refactor suggestions applied
* test: unit tests for cpuset * test: test added for podstate * test: changes made post PR
Signed-off-by: Philip Brownlow <philip.brownlow@intel.com>
* test: unit test for util.go * fix: addressing comments * change to fit recommendations * fixed for loops and tidied TestParseEndpointWithFallbackProtocol
In this commit: - all log and error messages start with a low letter - avoided caps in logs, error messages unless a specific ocject type was mentioned - c-states has been refactored to C-States where possible - boolean validation methods start with "validate" - test method names were refactored to Test$METHOD$_$CRLLER$_$TESTNAME$ Signed-off-by: Madalina Lazar <madalina.lazar@intel.com>
This PR contains the following changes: - all log and error messages start with a low letter - avoided caps in logs, error messages unless a specific object type was mentioned - c-states has been refactored to C-States where possible - boolean validation methods start with "validate" - test method names were refactored to TestCONTROLLER _ METHOD _TESTNAME Signed-off-by: Madalina Lazar <madalina.lazar@intel.com>
* docs: Readme update * highlights the existence of the diagrams directory * adds some basic info on acpi-cpufreq * refactors time of day section to match changes * docs: addressing readme suggestions
* unit tests for state * changes and updates
* fix: shared workload deletion bugfix * moves cores to reserved on shared workload deletion * sets shared profile to nil on shared profile deletion * fix: Addressing comments *simplifies moving of cores
* chore: version change and clean up * changes version form 2.2.0 to 2.3.0 * adds coverage check * fixes complaints from go vet * runs go mod tidy * chore: reflecting new release changes in diagrams *c hanges p-state to more generic "scaling driver" * fixes typo
Signed-off-by: Philip Brownlow <philip.brownlow@intel.com>
catblade
approved these changes
Aug 4, 2023
Contributor
catblade
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes Power Manager v2.3.0 additions: