Update MSVC on CI machines

[KornevNikita]

Is your feature request related to a problem? Please describe

As I understand the current version is:
-- The CXX compiler identification is MSVC 19.33.31629.0
This version contains a bug which leads to incorrect result for std::exp:
https://github.com/intel/llvm/actions/runs/13237411614/job/36945931639?pr=16939:
(1.64872,0)
When the expected result is:
https://godbolt.org/z/f3jhq3Yeo
(1.64872,-0)
Likely we need at least 19.40.33811.

Describe the solution you would like

No response

Describe alternatives you have considered

No response

Additional context

No response

[KornevNikita]

@uditagarwal97

[sarnex]

@uditagarwal97 have you started working on this? i need to update the gpu drivers this week so i can do this at the same time if you don't have a preference

[uditagarwal97]

@uditagarwal97 have you started working on this? i need to update the gpu drivers this week so i can do this at the same time if you don't have a preference

Hi @sarnex, not yet. Sure, feel free to take this up.

[sarnex]

cool

[sarnex]

@KornevNikita It looks like there are some tests that fail to compile on the new MSVC (I used the latest which is 19.43.34808), no idea if it's a new compiler bug or a product issue exposed.

Example:

********************
FAIL: SYCL :: WorkGroupScratchMemory/copy_dynamic_size.cpp (2085 of 2263)
******************** TEST 'SYCL :: WorkGroupScratchMemory/copy_dynamic_size.cpp' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
D:/github/_work/llvm/llvm/install/bin/clang++.exe  -Werror -fsycl -fsycl-targets=spir64  D:\github\_work\llvm\llvm\llvm\sycl\test-e2e\WorkGroupScratchMemory\copy_dynamic_size.cpp -o D:\github\_work\llvm\llvm\build-e2e\WorkGroupScratchMemory\Output\copy_dynamic_size.cpp.tmp.out
# executed command: D:/github/_work/llvm/llvm/install/bin/clang++.exe -Werror -fsycl -fsycl-targets=spir64 'D:\github\_work\llvm\llvm\llvm\sycl\test-e2e\WorkGroupScratchMemory\copy_dynamic_size.cpp' -o 'D:\github\_work\llvm\llvm\build-e2e\WorkGroupScratchMemory\Output\copy_dynamic_size.cpp.tmp.out'
# .---command stderr------------
# | D:\github\_work\llvm\llvm\llvm\sycl\test-e2e\WorkGroupScratchMemory\copy_dynamic_size.cpp:46:15: error: no matching function for call to 'min'
# |    46 |   auto size = std::min(
# |       |               ^~~~~~~~
# | C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.43.34808\include\utility:98:6: note: candidate template ignored: deduced conflicting types for parameter '_Ty' ('typename detail::is_device_info_desc<max_work_group_size>::return_type' (aka 'unsigned long long') vs. 'unsigned long')
# |    98 |     (min) (const _Ty& _Left _MSVC_LIFETIMEBOUND, const _Ty& _Right _MSVC_LIFETIMEBOUND)
# |       |      ^
# | C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.43.34808\include\xutility:7359:26: note: candidate template ignored: could not match 'initializer_list<_Ty>' against 'typename detail::is_device_info_desc<max_work_group_size>::return_type' (aka 'unsigned long long')
# |  7359 | _NODISCARD constexpr _Ty(min)(initializer_list<_Ty> _Ilist, _Pr _Pred) {
# |       |                          ^
# | C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.43.34808\include\xutility:7375:26: note: candidate function template not viable: requires single argument '_Ilist', but 2 arguments were provided
# |  7375 | _NODISCARD constexpr _Ty(min)(initializer_list<_Ty> _Ilist) {
# |       |                          ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.43.34808\include\utility:88:33: note: candidate function template not viable: requires 3 arguments, but 2 were provided
# |    88 | _NODISCARD constexpr const _Ty&(min) (const _Ty& _Left _MSVC_LIFETIMEBOUND, const _Ty& _Right _MSVC_LIFETIMEBOUND,
# |       |                                 ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |    89 |     _Pr _Pred) noexcept(noexcept(_Pred(_Right, _Left))) /* strengthened */ {
# |       |     ~~~~~~~~~
# | 1 error generated.
# `-----------------------------
# error: command failed with exit status: 1

Do you have bandwidth to investigate these or should I just file a Jira?

[KornevNikita]

@sarnex please create a ticket, I'm not an expert:) I was just told that we need a new compiler.

[KornevNikita]

BTW have you already updated it or just running locally?

[sarnex]

Made #17116

I updated it on the Windows BMG runner which isn't available in public CI here yet but is being used in a PR I have to test it.

For now I'll make it use the same MSVC version as all the other runners.