[SYCL] Move called function declaration to avoid recursion#10652
Merged
aelovikov-intel merged 1 commit intointel:syclfrom Aug 2, 2023
Merged
[SYCL] Move called function declaration to avoid recursion#10652aelovikov-intel merged 1 commit intointel:syclfrom
aelovikov-intel merged 1 commit intointel:syclfrom
Conversation
__vSignBitSet for float will in certain cases, due to a bug in GCC, convert its argument to double and call the corresponding function. To avoid recursion, the called double overload needs to be defined before the caller. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Comment on lines
+461
to
+463
| __SYCL_EXPORT s::cl_long __vSignBitSet(s::cl_double x) __NOEXC { | ||
| return -static_cast<s::cl_long>(std::signbit(x)); | ||
| } |
Contributor
There was a problem hiding this comment.
I was thinking about calling std::signbit(static_cast<s::cl_double>(x) at line 470 as an alternative. Either way is fine.
aelovikov-intel
approved these changes
Aug 2, 2023
Contributor
|
I don't see how can be related to this. |
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
__vSignBitSet for float will in certain cases, due to a bug in GCC, convert its argument to double and call the corresponding function. To avoid recursion, the called double overload needs to be defined before the caller. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__vSignBitSet for float will in certain cases, due to a bug in GCC, convert its argument to double and call the corresponding function. To avoid recursion, the called double overload needs to be defined before the caller.