[SYCL-MLIR] Tweak pipeline when -sycl-use-host-module is passed#10753
Merged
victor-eds merged 2 commits intointel:sycl-mlirfrom Aug 9, 2023
Merged
[SYCL-MLIR] Tweak pipeline when -sycl-use-host-module is passed#10753victor-eds merged 2 commits intointel:sycl-mlirfrom
victor-eds merged 2 commits intointel:sycl-mlirfrom
Conversation
added 2 commits
August 9, 2023 12:12
Apply following changes: - Do not skip `-loop-restructure` - Do not nest `-loop-internalization` pass Signed-off-by: Victor Perez <victor.perez@codeplay.com>
victor-eds
requested review from
Naghasan,
etiotto,
jopperm,
sommerlukas and
whitneywhtsang
as code owners
Author
|
Failing CUDA workflow unreleated. Should be disabled in this branch instead of removing the file to avoid future conflicts |
Naghasan
approved these changes
Aug 9, 2023
sommerlukas
approved these changes
Aug 9, 2023
| OptPM.addPass(polygeist::createLoopInternalizationPass( | ||
| PM.addPass(polygeist::createLoopInternalizationPass( | ||
| {options.getCgeistOpts().getRelaxedAliasing()})); | ||
| mlir::OpPassManager &OptPM = |
Contributor
There was a problem hiding this comment.
To improve visibility, can we put line 454 to 473 under braces too? And put createInlinePass after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply following changes:
-loop-restructure-loop-internalizationpasssycl.[nd_]range.constructorinUniformityAnalysisSigned-off-by: Victor Perez victor.perez@codeplay.com