[SYCL][Bindless] Add support for mipmap data types smaller than 32-bit #10856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DBDuncan
force-pushed
the
duncan/add-mipmap-dtypes
branch
from
828527a to
6db0988
Compare
DBDuncan
changed the title
Contributor
|
Friendly ping for @intel/llvm-reviewers-runtime and @intel/llvm-reviewers-cuda |
steffenlarsen
approved these changes
Sep 1, 2023
Contributor
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
Just some minor comments. I think it looks good overall.
DBDuncan
force-pushed
the
duncan/add-mipmap-dtypes
branch
from
6db0988 to
8093bcb
Compare
DBDuncan
force-pushed
the
duncan/add-mipmap-dtypes
branch
from
8093bcb to
d2679fe
Compare
This commit adds support for data types smaller then 32-bit for mipmaps. The added types are short, short2, short4, ushort, ushort2, ushort4, char, char2, char4, uchar, uchar2, uchar4, half, half2, and half4. Mipmap tests have been modified to test all valid data types. `image.cl` has also been refactored to reduce code duplication.
DBDuncan
force-pushed
the
duncan/add-mipmap-dtypes
branch
from
d2679fe to
14fcf07
Compare
Contributor
Author
|
Thanks for the feedback Steffen. Would have responded much earlier but unfortunately I was on holiday when I got your feedback. |
przemektmalon
approved these changes
Sep 18, 2023
isaacault
approved these changes
Sep 18, 2023
Contributor
Author
|
@intel/llvm-gatekeepers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for data types smaller then 32-bit for mipmaps.
The added types are short, short2, short4, ushort, ushort2, ushort4, char, char2, char4, uchar, uchar2, uchar4, half, half2, and half4. Mipmap tests have been modified to test all valid data types.
image.clhas also been refactored to reduce code duplication.