Skip to content

Conversation

@Alcpz
Copy link

@Alcpz Alcpz commented Aug 23, 2023

This is the 3rd implementation PR of SYCLcompat. SYCLcompat primary goals and features are documented here.

The PR includes the code that would implement the wrapper to expose memory operations, using USM. The exposed functionalities include, synchronous and asynchronous memset, memcpy, and fill operations; malloc and free operations; and a helper classes to query allocation type for memory pointers using SYCLcompat.

@Alcpz Alcpz requested a review from a team as a code owner August 23, 2023 10:55
Copy link
Contributor

@joeatodd joeatodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions but on the whole looks great! Thanks @Alcpz

Copy link
Author

@Alcpz Alcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeatodd I've addressed all the issues.

Co-authored-by: Joe Todd <joe.todd@codeplay.com>
Co-authored-by: Pietro Ghiglio <pietro.ghiglio@codeplay.com>
@Alcpz Alcpz force-pushed the Alcpz/syclcompat-memory-api branch from bd54443 to 6bc4e73 Compare August 30, 2023 10:25
@Alcpz
Copy link
Author

Alcpz commented Aug 30, 2023

@intel/llvm-gatekeepers We think this PR is ready for being merged. Thanks!.

@aelovikov-intel aelovikov-intel merged commit 4dfaf20 into intel:sycl Aug 30, 2023
@Alcpz Alcpz deleted the Alcpz/syclcompat-memory-api branch August 30, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants