-
Notifications
You must be signed in to change notification settings - Fork 802
[SYCL][COMPAT] Added USM memory #10939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][COMPAT] Added USM memory #10939
Conversation
joeatodd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions but on the whole looks great! Thanks @Alcpz
Alcpz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joeatodd I've addressed all the issues.
Co-authored-by: Joe Todd <joe.todd@codeplay.com> Co-authored-by: Pietro Ghiglio <pietro.ghiglio@codeplay.com>
bd54443 to
6bc4e73
Compare
|
@intel/llvm-gatekeepers We think this PR is ready for being merged. Thanks!. |
This is the 3rd implementation PR of SYCLcompat. SYCLcompat primary goals and features are documented here.
The PR includes the code that would implement the wrapper to expose memory operations, using USM. The exposed functionalities include, synchronous and asynchronous
memset,memcpy, andfilloperations;mallocandfreeoperations; and a helper classes to query allocation type for memory pointers using SYCLcompat.