-
Notifications
You must be signed in to change notification settings - Fork 802
[SYCL-MLIR][CI] Trigger SYCL MLIR Pre Commit on Linux workflow
#10956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SYCL MLIR Pre Commit on Linux workflow
|
@bader you were totally right. I checked what was going on and, apparently, despite naming a different workflow in the |
Why |
Nowhere to be found. I'm no CI expert, but, looking at previous jobs, it seems our workflow was being run with a different name (?). |
My understanding is: https://github.com/intel/llvm/blob/sycl/.github/workflows/sycl_precommit_aws.yml use
So as long as the workflow name pre commit testing is And according to https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows
So changing the workflow name in sycl_precommit_aws.yml in SYCL-MLIR branch won't help, as it is not on the default branch. So yeah, it is good idea to rename the workflow for SYCL-MLIR branch to something else other than |
We already had: name: SYCL MLIR Pre Commit on Linuxbut our workflow appeared with the |
Where do you see that? |
Here you can see jobs triggered by PRs both targeting |
I can't tell enough how I hate Github Actions after working with them very closely for the last half a year. Everything looks cumbersome, unfinished and buggy. The developers seem to jump from one thing to another without polishing anything for the release quality... |
This looks definitely like a bug to me (maybe they'll document it and make it a feature now 😆). Thanks for the reviews guys, CI can be painful. |
Rename the workflow file so that our own
SYCL MLIR Pre Commit on Linuxis triggered instead ofSYCL Pre Commit on Linux.The latter lead to an additional job testing SYCL-MLIR on CUDA devices (always failing).
Note: Future changes in
syclbranch CI may lead to conflicts when merging.